Skip to content

[Bugfix] Fix invalid rotary embedding unit test #13431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

[Bugfix] Fix invalid rotary embedding unit test #13431

merged 1 commit into from
Feb 18, 2025

Conversation

@liangfu
Copy link
Contributor

@liangfu liangfu commented Feb 17, 2025 •
edited by github-actions bot
Loading

With base=0, the cos_sin_cache would be initialized with NaN:

self.cos_sin_cache
tensor([[ 1.0000,     nan,     nan,     nan,     nan,     nan,     nan,     nan,
             nan,     nan,     nan,     nan,     nan,     nan,     nan,     nan,
          0.0000,     nan,     nan,     nan,     nan,     nan,     nan,     nan,
             nan,     nan,     nan,     nan,     nan,     nan,     nan,     nan],
        [ 0.5403,     nan,     nan,     nan,     nan,     nan,     nan,     nan,
             nan,     nan,     nan,     nan,     nan,     nan,     nan,     nan,
          0.8415,     nan,     nan,     nan,     nan,     nan,     nan,     nan,
             nan,     nan,     nan,     nan,     nan,     nan,     nan,     nan],
        [-0.4161, ...]
        [...]])

This PR fix the unit test script to generate reasonable test cases, by changing base argument to base=10000.

@github-actions
Copy link

github-actions bot commented Feb 17, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@liangfu
[Bugfix] Fix invalid rotary embedding unit test
2e269de 
Signed-off-by: Liangfu Chen <liangfc@amazon.com>
DarkLight1337
DarkLight1337 approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 18, 2025 06:34
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 18, 2025
@DarkLight1337 DarkLight1337 merged commit 3809458 into vllm-project:main Feb 18, 2025
43 checks passed
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
@liangfu
[Bugfix] Fix invalid rotary embedding unit test (vllm-project#13431)
6d76ea3 
Signed-off-by: Liangfu Chen <liangfc@amazon.com>
meffmadd pushed a commit to meffmadd/vllm that referenced this pull request Feb 21, 2025
@liangfu @meffmadd
[Bugfix] Fix invalid rotary embedding unit test (vllm-project#13431)
80a653b 
Signed-off-by: Liangfu Chen <liangfc@amazon.com>
Signed-off-by: Matt, Matthias <matthias.matt@tuwien.ac.at>
@liangfu liangfu deleted the patch-1 branch February 25, 2025 06:29
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@liangfu @Akshat-Tripathi
[Bugfix] Fix invalid rotary embedding unit test (vllm-project#13431)
bbfee9a 
Signed-off-by: Liangfu Chen <liangfc@amazon.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@liangfu @lulmer
[Bugfix] Fix invalid rotary embedding unit test (vllm-project#13431)
e83d9a5 
Signed-off-by: Liangfu Chen <liangfc@amazon.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@liangfu @shreyankg
[Bugfix] Fix invalid rotary embedding unit test (vllm-project#13431)
2e3a7ee 
Signed-off-by: Liangfu Chen <liangfc@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liangfu @DarkLight1337